Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Deprecate to_torch #48692

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[Data] Deprecate to_torch #48692

merged 3 commits into from
Nov 12, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 11, 2024 •
edited
Loading

Why are these changes needed?

We recommend iter_torch_batches over to_torch. To avoid confusion, we shouldn’t have two similar APIs, especially if we always prefer one.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
4c01087 
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
omatthew98
omatthew98 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@omatthew98 omatthew98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

bveeramani and others added 2 commits November 12, 2024 12:22
@bveeramani
Add docs
a949e2e 
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani
Merge branch 'master' into deprecate-to-torch
d855514 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani enabled auto-merge (squash) November 12, 2024 21:44
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 12, 2024
@bveeramani bveeramani merged commit 6e5584e into master Nov 12, 2024
7 checks passed
@bveeramani bveeramani deleted the deprecate-to-torch branch November 12, 2024 22:37
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Deprecate to_torch (ray-project#48692)
14d5abb 
We recommend `iter_torch_batches` over `to_torch`. To avoid confusion,
we shouldn’t have two similar APIs, especially if we always prefer one.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
[Data] Deprecate to_torch (ray-project#48692)
e241224 
We recommend `iter_torch_batches` over `to_torch`. To avoid confusion,
we shouldn’t have two similar APIs, especially if we always prefer one.

---------

Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omatthew98 omatthew98 omatthew98 approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin alexeykudinkin is a code owner

@srinathk10 srinathk10 Awaiting requested review from srinathk10 srinathk10 is a code owner

Assignees

@omatthew98 omatthew98

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bveeramani @omatthew98